Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX/angular] Allow view/edit in new tabs from list view #22801

Closed
1 task done
nitram84 opened this issue Jul 7, 2023 · 1 comment · Fixed by #22888
Closed
1 task done

[UX/angular] Allow view/edit in new tabs from list view #22801

nitram84 opened this issue Jul 7, 2023 · 1 comment · Fixed by #22888
Labels
javascript Pull requests that update Javascript code theme: angular theme: react theme: vue
Milestone

Comments

@nitram84
Copy link
Contributor

nitram84 commented Jul 7, 2023

Overview of the issue

With the current implementation (angular, jhipster 7.9.3/8.0.0-beta.1) it is possible to open an item from the list view in a new tab (use linked ID in ID column). In the new tab switching to edit mode an editing is possible.
But the view and edit function on the right side is implemented with buttons. Therefore is not possible to open or edit in new tabs items in this way. If you simply replace <button submit="true" ... </button> with <a ... </a>, working in tabs would be possible, even without layout changes.

Is there any reason why viewing and editing in new tabs is allowed on the left side and disallowed on the right side?

Motivation for or Use Case

A workflow where items could be opened and edited in new tabs would improve productivity, especially when items where filtered or sorted in list view. It would be possible to open all items to process in new tabs without loosing the filtered/sorted list/search result and to edit the items tab for tab.

Reproduce the error

Open list view of any entity. It is not possible to view/edit an item in a new tab with the buttons in the right side.

Related issues
Suggest a Fix

Replacing the buttons with a link solves the problem.

JHipster Version(s)

7.9.3, 8.0.0-beta.1

JHipster configuration

No specific configuration needed. Just use angular and define at least one entity.

Entity configuration(s) entityName.json files generated in the .jhipster directory
Browsers and Operating System

any

  • Checking this box is mandatory (this is just to show you read everything)
@mraible
Copy link
Contributor

mraible commented Jul 7, 2023

Can you please create a PR to change to what you're proposing? That way, we can see if all CI tests pass or if further refinements need to be made. Please keep in mind that you might need to modify Angular, React, and Vue templates.

nitram84 added a commit to nitram84/generator-jhipster that referenced this issue Jul 17, 2023
nitram84 added a commit to nitram84/generator-jhipster that referenced this issue Oct 26, 2023
@deepu105 deepu105 added this to the 8.0.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code theme: angular theme: react theme: vue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants