Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 8.0.0-beta.3 has lots of templates with wrong permissions. #23440

Closed
1 task
mshima opened this issue Sep 7, 2023 · 6 comments
Closed
1 task

Version 8.0.0-beta.3 has lots of templates with wrong permissions. #23440

mshima opened this issue Sep 7, 2023 · 6 comments
Milestone

Comments

@mshima
Copy link
Member

mshima commented Sep 7, 2023

Overview of the issue

Published package has a lot of templates with wrong permission:

% find node_modules/generator-jhipster/dist/ -type f -perm 0755
node_modules/generator-jhipster/dist//cli/jhipster.cjs
node_modules/generator-jhipster/dist//generators/kubernetes-helm/USAGE
node_modules/generator-jhipster/dist//generators/kubernetes-helm/templates/csvc/requirements.yml.ejs
node_modules/generator-jhipster/dist//generators/kubernetes-helm/templates/csvc/helpers.tpl.ejs
node_modules/generator-jhipster/dist//generators/kubernetes-helm/templates/csvc/Chart.yml.ejs
node_modules/generator-jhipster/dist//generators/kubernetes-helm/templates/csvc/values.yml.ejs
node_modules/generator-jhipster/dist//generators/kubernetes-helm/templates/README-KUBERNETES-HELM.md.ejs
node_modules/generator-jhipster/dist//generators/init/templates/.husky/pre-commit
.
.
.
node_modules/generator-jhipster/dist//generators/server/USAGE
node_modules/generator-jhipster/dist//generators/server/templates/micro_services_architecture.md
node_modules/generator-jhipster/dist//generators/server/templates/npmw
node_modules/generator-jhipster/dist//generators/server/templates/src/test/resources/META-INF/services/reactor.blockhound.integration.BlockHoundIntegration.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/test/resources/templates/mail/passwordResetEmail.html.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/test/resources/templates/mail/testEmail.html.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/test/resources/templates/mail/activationEmail.html.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/test/resources/templates/mail/creationEmail.html.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/test/resources/i18n/messages_en.properties.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/test/resources/junit-platform.properties.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/test/java/package/web/filter/ModifyServersOpenApiFilterTest.java.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/main/docker/jib/entrypoint.sh.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/main/resources/templates/mail/passwordResetEmail.html.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/main/resources/templates/mail/activationEmail.html.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/main/resources/templates/mail/creationEmail.html.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/main/resources/templates/error.html.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/main/java/package/config/ReactorConfiguration.java.ejs
node_modules/generator-jhipster/dist//generators/server/templates/src/main/java/package/web/filter/ModifyServersOpenApiFilter.java.ejs
node_modules/generator-jhipster/dist//generators/export-jdl/USAGE
node_modules/generator-jhipster/dist//generators/languages/USAGE
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_by.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_ta.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_uz_Cyrl_UZ.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_cs.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_my.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_th.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_si.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_fa.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_fi.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_gl.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_sk.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_es.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_hi.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_et.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_te.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_mr.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_ua.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_al.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_nl.properties.ejs
node_modules/generator-jhipster/dist//generators/languages/templates/src/test/resources/i18n/messages_ro.properties.ejs
.
.
.
node_modules/generator-jhipster/dist//generators/kubernetes/templates/skaffold/skaffold.yml.ejs
node_modules/generator-jhipster/dist//generators/kubernetes/templates/istio/destination-rule.yml.ejs
node_modules/generator-jhipster/dist//generators/kubernetes/templates/istio/virtual-service.yml.ejs
node_modules/generator-jhipster/dist//generators/kubernetes/templates/secret/couchbase-secret.yml.ejs
node_modules/generator-jhipster/dist//generators/kubernetes/templates/kustomize/patch/istio-namespace.yml.ejs
node_modules/generator-jhipster/dist//generators/kubernetes/templates/kustomize/patch/istio-label.yml.ejs
node_modules/generator-jhipster/dist//generators/client/USAGE
node_modules/generator-jhipster/dist//generators/openapi-client/USAGE
node_modules/generator-jhipster/dist//generators/openapi-client/templates/java/.openapi-generator-ignore
node_modules/generator-jhipster/dist//generators/openapi-client/templates/spring/.openapi-generator-ignore

Current git:

generator-jhipster % find generators/ -type f -perm 0755
generators//init/templates/.husky/pre-commit
generators//docker/templates/src/main/docker/config/keycloak-health-check.sh
generators//maven/templates/mvnw
generators//server/templates/npmw
generators//gradle/templates/gradlew
generators//kubernetes-knative/templates/kubectl-apply.sh.ejs
generators//common/templates/.husky/pre-commit.ejs
generators//generate-blueprint/generator.spec.mjs
generators//generate-blueprint/templates/cli/cli.mjs.ejs
generators//generate-blueprint/templates/generators/generator/templates/template-file.ejs
generators//docker-compose/templates/realm-config/keycloak-health-check.sh
generators//kubernetes/templates/kubectl-apply.sh.ejs
Motivation for or Use Case
Reproduce the error
Related issues
Suggest a Fix
JHipster Version(s)
JHipster configuration
Entity configuration(s) entityName.json files generated in the .jhipster directory
Browsers and Operating System
  • Checking this box is mandatory (this is just to show you read everything)
@mraible
Copy link
Contributor

mraible commented Sep 27, 2023

@deepu105 Could this be related to the beta.3 release you did?

@deepu105
Copy link
Member

deepu105 commented Sep 27, 2023

Strange. I released from linux so there shouldn't be windows issue. So i guess the templates were committed with wrong permission flags. Also I'm confused why does it matter? templates are not executable right

@DanielFran
Copy link
Member

@mshima also identified issues in yeoman...

@mshima
Copy link
Member Author

mshima commented Sep 27, 2023

@deepu105 generated files will match templates file mode. Yeoman is aware of file mode, it detects and applies.
Those files had wrong permission in git a few months back. Git won't apply the new file mode so this will update the file mode:

rm -rf generators
git checkout generators

@DanielFran yep, those issues should be fixed in yeoman/yeoman-api@0cbf162 and yeoman/yeoman-api@82a9e67.
Not part of beta.3.

I think we should go on and release the npm package with release script.

@deepu105
Copy link
Member

deepu105 commented Sep 27, 2023 via email

@mraible
Copy link
Contributor

mraible commented Oct 24, 2023

@mshima @deepu105 I'm closing this as resolved. Please re-open if it's not fixed.

@mraible mraible closed this as completed Oct 24, 2023
@deepu105 deepu105 added this to the 8.0.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants