Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parse method to encode illegal tag in html body #1359

Closed
wants to merge 1 commit into from

Conversation

InanisV
Copy link

@InanisV InanisV commented Apr 20, 2020

Fixes #1230

@jhy
Copy link
Owner

jhy commented Jul 15, 2021

Thanks, but no thanks. Sorry for the late reply. A few thoughts:

If we were to add this functionality, I think it makes more sense as an option to the Cleaner - what to do on an error - drop or escape.

The internal use of reflection strikes me as an odd pattern here. If we wanted to access these fields it would be better to make public methods, and not bind it completely to the current implementation.

The naming of things as 'legal' and 'illegal' doesn't really make sense to me. All of these tags are valid HTML. Maybe known/unknown would be better.

@jhy jhy closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to encode illegal tag in html body
2 participants