Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not reproject the internal Adam states during update_proj_gap? #54

Open
liuliu opened this issue Jun 30, 2024 · 2 comments
Open

Why not reproject the internal Adam states during update_proj_gap? #54

liuliu opened this issue Jun 30, 2024 · 2 comments

Comments

@liuliu
Copy link

liuliu commented Jun 30, 2024

Hi, great project. After reading the paper and the implementation, I am wondering if it is considered to reproject the Adam internal states (exp_avg, exp_avg_sq) from previous subspace to the new subspace?

@liuliu
Copy link
Author

liuliu commented Jun 30, 2024

The reproj momentum is mentioned in the FLoRA paper.

@jiaweizzhao
Copy link
Owner

Hi, thanks for the suggestion. We didn't include reprojection in the paper but will try to implement it in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants