Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Twitter Logo. #6089

Closed
niranjan-kurhade opened this issue Oct 18, 2023 · 20 comments · Fixed by #6092 · May be fixed by #6131
Closed

Update the Twitter Logo. #6089

niranjan-kurhade opened this issue Oct 18, 2023 · 20 comments · Fixed by #6092 · May be fixed by #6131
Assignees
Labels

Comments

@niranjan-kurhade
Copy link

Describe your proposal/problem

In the footer of the docs, we are still using the old logo of Twitter. https://docs.jina.ai/


Screenshots
image

Solution
Update the Logo of Twitter to latest logo (X).

@niranjan-kurhade
Copy link
Author

Please assign this issue to me! I would like to work on it.

@JoanFM
Copy link
Member

JoanFM commented Oct 18, 2023

Hello @niranjan-kurhade ,

it would be nice to get your contribution

@niranjan-kurhade
Copy link
Author

Hello @niranjan-kurhade ,

it would be nice to get your contribution

Thanks! Will create a PR soon!

@AbhiGaunker
Copy link
Contributor

AbhiGaunker commented Oct 20, 2023

Even I am trying to attempt this issue

AbhiGaunker added a commit to AbhiGaunker/jina that referenced this issue Oct 20, 2023
@AbhiGaunker
Copy link
Contributor

Sir Pls check and approve the code for merging if no issues found. Waiting for your reply

@JoanFM JoanFM linked a pull request Oct 20, 2023 that will close this issue
1 task
@JoanFM JoanFM closed this as completed Oct 20, 2023
@AbhiGaunker
Copy link
Contributor

Thank you

@niranjan-kurhade
Copy link
Author

Hey @JoanFM, I was assigned this issue and was going to make a PR soon. 🥲

@JoanFM JoanFM reopened this Oct 21, 2023
@JoanFM
Copy link
Member

JoanFM commented Oct 21, 2023

@nikitashrivastava29 ,

I think the solution provided by @AbhiGaunker does not work, at least on my phone. Perhaps you had a different approach to the solution?

@niranjan-kurhade
Copy link
Author

@nikitashrivastava29 ,

I think the solution provided by @AbhiGaunker does not work, at least on my phone. Perhaps you had a different approach to the solution?

I have been assigned this issue originally, should I make a PR?

@JoanFM
Copy link
Member

JoanFM commented Oct 21, 2023

yes please

@AbhiGaunker
Copy link
Contributor

Sorry for that @JoanFM @niranjan-kurhade , as discussed before I got the right icon but Forget to update fontawesome version to its latest one. Since older version does not have the new logo we need to change it, I think we have version 5 installed currently

@JoanFM
Copy link
Member

JoanFM commented Oct 25, 2023

Hey @AbhiGaunker , can u lead us to how to fix the current issue?

@JoanFM
Copy link
Member

JoanFM commented Oct 25, 2023

I am reverting the change so far in #6096

@SkitzAvernal
Copy link

If you guys don’t mind, I’d like a crack at doing this.

@JoanFM
Copy link
Member

JoanFM commented Nov 18, 2023

If you guys don’t mind, I’d like a crack at doing this.

perfect

@reshma045
Copy link

reshma045 commented Dec 17, 2023

@JoanFM is the issue solved or still open?

@JoanFM
Copy link
Member

JoanFM commented Dec 17, 2023

it is still open

@niranjan-kurhade
Copy link
Author

it is still open

Hey @JoanFM, Please check I have made a PR to fix this.

@JoanFM JoanFM linked a pull request Dec 22, 2023 that will close this issue
@shaheer21-sys
Copy link

is this issue still open? if that's the case I'd like to fix it , assign it to me

@jina-bot
Copy link
Member

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants