-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect native arch dynamically #11
Comments
If you can give me pointers I can probably handle this and submit a PR. Update: After some research can't we use |
I have the same issue. This fails on my arm64 runner, because it can't execute the x86 binaries. And on this line: Line 181 in 359b91e
it sets up qemu for any architecture that isn't x86. Instead, it should set up qemu for any architecture that isn't native. |
Also this default is a problem: Lines 9 to 15 in 359b91e
It hard-codes for x86_64 binaries, and requires a sha256 to be valid. |
GitHub now offers free aarch64 runners: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ Automatically select the default apk-tools-url and arch to match the CPU architecture of the current runner. Run armv7 and armhf without QEMU on aarch64 runners. For symmetry, allow emulating x86 and x86_64 on aarch64. Document how to run aarch64 without emulation. Change existing aarch64 examples to s390x, to avoid encouraging emulation of aarch64. Fixes jirutka#11.
GitHub now offers free aarch64 runners: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ Automatically select the default apk-tools-url and arch to match the CPU architecture of the current runner. Run armv7 and armhf without QEMU on aarch64 runners. For symmetry, allow emulating x86 and x86_64 on aarch64. Document how to run aarch64 without emulation. Change existing aarch64 examples to ppc64le, to avoid encouraging emulation of aarch64. Fixes jirutka#11.
Currently from what I read from the setup script. It seems anything which is not x86 will setup qemu. However in the use case where we're using a self hosted runner that the host is natively aarch64 it should not setup qemu.
The text was updated successfully, but these errors were encountered: