Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Typescript in Cloud Functions #671

Open
jkomoros opened this issue Oct 24, 2023 · 1 comment
Open

Use Typescript in Cloud Functions #671

jkomoros opened this issue Oct 24, 2023 · 1 comment

Comments

@jkomoros
Copy link
Owner

jkomoros commented Oct 24, 2023 •
edited
Loading

See also #601 .

Blocks #656 and #646

https://firebase.google.com/docs/functions/typescript#migrating_an_existing_javascript_project_to_typescript
@jkomoros
Copy link
Owner Author

jkomoros commented Oct 24, 2023 •
edited
Loading

  • no implicit any
  • Use type definitions from main package instead of recreating them
  • De-dupe tweet-helpers

jkomoros added a commit that referenced this issue Oct 28, 2023
@jkomoros
BIG COMMIT. Switch to using typescript in functions.
424d508 
This requires a lot of smaller changes to make typescript not complain, which includes a few bug fixes caught by typescript.

The functions currently don't deploy (eslint warnings). Functions likely have broken, perhaps in big ways. Each one should be methodically tested before this is merged to master.

Part of #671.
jkomoros added a commit that referenced this issue Oct 28, 2023
@jkomoros
Tighten eslint config.
5ebcd64 
A few eslint warnings still exist, so functions don't yet deploy.

Part of #671.
jkomoros added a commit that referenced this issue Oct 28, 2023
@jkomoros
Fix all but one eslint error.
2da8213 
Part of #671.
jkomoros added a commit that referenced this issue Oct 28, 2023
@jkomoros
Resolve remaining eslint error.
f558422 
Part of #671.
jkomoros added a commit that referenced this issue Oct 28, 2023
@jkomoros
Add some more puppeteer configuration to try to get it to work.
882a690 
Following sintructions in https://hume.dev/articles/puppeteer-google-cloud-functions-v2/

Still doesn't work.

Part of #671.
jkomoros added a commit that referenced this issue Oct 28, 2023
@jkomoros
Downgrade puppeteer version to get it working again.
5094bd6 
Followed instructions here: https://stackoverflow.com/a/74601573

The screenshot service now works again.

Part of #671.
jkomoros added a commit that referenced this issue Oct 28, 2023
@jkomoros
Switch to typescript for cloud functions.
e55cd35 
legal, screenshot, and openai endpoints are verified to work. email and tweet endpoints aren't verified to work, but those were also already defunct.

Part of #671.

Merge branch 'typescript-functions'

* typescript-functions:
  Downgrade puppeteer version to get it working again.
  Add some more puppeteer configuration to try to get it to work.
  Resolve remaining eslint error.
  Fix all but one eslint error.
  Tighten eslint config.
  BIG COMMIT. Switch to using typescript in functions.
jkomoros added a commit that referenced this issue Oct 29, 2023
@jkomoros
More aggressive gitignore for functions lib
5b49301 
Part of #671.
jkomoros added a commit that referenced this issue Oct 29, 2023
@jkomoros
Get rid of a complaining eslint.
44a2c77 
Part of #671.
jkomoros added a commit that referenced this issue Oct 29, 2023
@jkomoros
Resolved a type error
254b21e 
Part of #671.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkomoros