Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many cards in production have id field of ?DEFAULT-INVALID-ID? #672

Open
jkomoros opened this issue Oct 29, 2023 · 0 comments
Open

Many cards in production have id field of ?DEFAULT-INVALID-ID? #672

jkomoros opened this issue Oct 29, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jkomoros
Copy link
Owner

jkomoros commented Oct 29, 2023 •
edited
Loading

Found while working on #646

On first save we likely store the ID.

The effect is shadowed on the client because we have each card obj be {...rec.data(), id}, but something that looks at DB directly will get confused.

Needs a maintenance task and also to fix the behavior
@jkomoros jkomoros added the bug Something isn't working label Oct 29, 2023
jkomoros added a commit that referenced this issue Oct 29, 2023
@jkomoros
Switch to override the firestore id in the card.
12db67e 
See #672 for why.

Part of #646.
@jkomoros jkomoros mentioned this issue Oct 29, 2023
Open
jkomoros added a commit that referenced this issue Oct 29, 2023
@jkomoros
Add two notes about why an implementation is that way.
2afffad 
Part of #672. Part of #646.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkomoros