Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Authentication using SecureString #67

Open
Vejahatf opened this issue Dec 6, 2018 · 0 comments
Open

Basic Authentication using SecureString #67

Vejahatf opened this issue Dec 6, 2018 · 0 comments

Comments

@Vejahatf
Copy link

Vejahatf commented Dec 6, 2018

I see that the StashApiCSharp supports basic authentication using string for password . wouldn't it better to add support for SecureString in order to avoid possible risk of exposing sensitive data in managed memory?
I was thinking to add a new
public HttpCommunicationWorker(string baseUrl, string username, SecureString password)
{
var httpClientHandler = new HttpClientHandler
{
Credentials = new NetworkCredential(username, password)
};

        _httpClient = new HttpClient(httpClientHandler) {BaseAddress = new Uri(baseUrl)};

    }

Thanks,
Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant