Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MuxedLines::remove_file #12

Open
jmagnuson opened this issue Apr 30, 2020 · 0 comments
Open

Implement MuxedLines::remove_file #12

jmagnuson opened this issue Apr 30, 2020 · 0 comments

Comments

@jmagnuson
Copy link
Owner

Same for MuxedEvents to sync with notify. The mechanics already exist for deregistration between watching and pending; remove_file would just wipe out any entry for a particular PathBuf.

A case could be made that only the absolutified-PathBuf returned from add_file should be accepted (as that is technically the watch 'token'), but accepting either would be more robust, and an error would need to be propagated regardless of pre- or post-absolutification input anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant