Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer English names logic is broken #369

Closed
adamcandy opened this issue Apr 20, 2020 · 4 comments
Closed

Prefer English names logic is broken #369

adamcandy opened this issue Apr 20, 2020 · 4 comments
Labels

Comments

@adamcandy
Copy link
Contributor

bool cannot be used to test for a True or False string in python.

In elodie/geolocation.py:

__PREFER_ENGLISH_NAMES__ = bool(config['MapQuest']['prefer_english_names'])

will evaluate to True for any string specified!

@adamcandy
Copy link
Contributor Author

Fixed in PR 370.

@jmathai jmathai added the bug label Apr 22, 2020
@crishnakh
Copy link

Hi, is this bug related to the config prefer_english_names=False ?
Because I set it in the config.ini but the locations names are still cerated in English.

@adamcandy
Copy link
Contributor Author

Yes @crishnakh exactly. The fix in PR 370 sorts all the problems I had with this option, so give this a try. I should get around to merging this change in together with some others. I think @jmathai wanted me to combine the PRs rather than pull in individually.

@jmathai
Copy link
Owner

jmathai commented Nov 18, 2022

The new MapQuest API no longer supports this functionality. Have opened #425 to track it but will probably just mark the capability as deprecated.

@jmathai jmathai closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants