Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with PHP 8 #39

Open
gijo-varghese opened this issue Mar 16, 2021 · 5 comments
Open

Not compatible with PHP 8 #39

gijo-varghese opened this issue Mar 16, 2021 · 5 comments

Comments

@gijo-varghese
Copy link

gijo-varghese commented Mar 16, 2021

Doesn't seems to be compatible with PHP 8.0

<?php
require 'vendor/autoload.php';

$downloader = \JMathai\PhpMultiCurl\MultiCurl::getInstance();

$request = $downloader->addUrl('https://example.com');

echo 'Done';

will throw error: PHP Fatal error: Uncaught Error: Class "JMathai\PhpMultiCurl\MultiCurlInvalidParameterException" not found in /test-project/vendor/jmathai/php-multi-curl/src/MultiCurl.php:681

@thevilx
Copy link

thevilx commented May 4, 2021

Same Here !

@gijo-varghese
Copy link
Author

@thevilx I switched to this one: https://gist.github.com/nicklasos/365a251d63d94876179c

Working great for me

@cesurce
Copy link

cesurce commented Aug 10, 2024

  1. line change to if(gettype($ch) !== 'object')
  2. line change to return get_class($ch);

@kicks66
Copy link

kicks66 commented Oct 5, 2024

@cesurce I don't think this fix works - this still gives errors

a shame as I love this library < PHP 8

@cesurce
Copy link

cesurce commented Oct 8, 2024

@cesurce I don't think this fix works - this still gives errors

a shame as I love this library < PHP 8

worked for me on PHP 8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants