Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not instanceof Backbone.Collection #10

Open
ben-ng opened this issue Mar 13, 2015 · 1 comment
Open

Not instanceof Backbone.Collection #10

ben-ng opened this issue Mar 13, 2015 · 1 comment

Comments

@ben-ng
Copy link

ben-ng commented Mar 13, 2015

This module is incompatible with code that checks for obj instanceof Backbone.Collection. Is there a reason why these collections aren't simply extended from Backbone.Collection?

@jmorrell
Copy link
Owner

If you use Obscura directly, it would pass https://github.com/jmorrell/backbone.obscura/blob/master/index.js#L129 but it was too much work to repeat it for all of the sub-collections.

I originally split this into 4 modules, but today I'd keep it as only one since they ended up being pretty coupled in the end. Changes to any of them required rebuilding all of the higher dependencies, and too many of the changes needed to apply to all of them, leading to too much thrash. I'd also love to get rid of the three different types of subcollections and just do a diff against the previous state, but since I don't use these modules myself anymore there's not a lot of motivation to do that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants