Download all missing songs on playlist/album

[pedrotrschneider]

If I create a playlist and download it, I can play it normally in offline mode. However, if I then add a new song to the playlist, it no longer appears in offline mode, as if it was never downloaded. Furthermore, there is no option to download the single song I added to the playlist, and I need to delete all other downloaded songs, and then download the entire playlist again.

Is this an actual bug or am I missing something? I am aware of #213, but I didn't see this specific issue mentioned there, or anywhere else, that's why I'm opening this one.

If this is actually a bug, I would suggest either adding a "download all missing songs on playlist/album" button alongside the "delete downloads" button, or identifying when a downloaded playlist has tracks that are not downloaded and change the "delete downloads" button to a "download missing tracks" button. I prefer the first option, since the second option would make it impossible to delete all tracks on the playlist without downloading the rest of them first, but maybe something in-between would be a good idea.

Another option to mitigate this issue would be to make the "downloaded" property local to tracks. I think this would be a good idea. Right now, I have to either download the entire album/playlist or create another playlist if I want to listen to some of the songs in an album/playlist. If there are any downloaded tracks in a playlist/album, I think they should already show up in offline mode, and not require all songs to be downloaded.

[Y0ngg4n]

It is missing. But i am currently working on a pull request to enhance the downloads. Maybe just wait.

[Demian98]

@Y0ngg4n It would be great if your enhancements would also include an option to restart failed downloads. Currently we also need to delete an redownload the full album in case one download fails.

[Y0ngg4n]

@Demian98 that is exactly what i try to implement currently

[Y0ngg4n]

#331

[seniorm0ment]

I do encounter this as well, was curious if there was any updates on it?
If I add a new song to a playlist it doesn't automatically download it if I previously downloaded that playlist.

[JPinSPACE]

I just wanted to add my voice saying that this is still a problem. I maintain a lengthy "general" playlist to throw on shuffle while in the car. But any time I add anything to the playlist if I want it to work in offline mode I have to delete the playlist and allow it to redownload, which usually takes a couple of attempts and uses so much data that I can only do it on wifi.

[Y0ngg4n]

@JPinSPACE have you tried the retry downloads button in the downloads page?

[JPinSPACE]

I just tried it. It just says I don't have any download errors. It's not an error per se, it's just that the playlist now has extra songs at the end and in the past I had downloaded the playlist. The expected behavior is that the playlist would understand its status as "downloaded", see that it now has undownloaded songs on the end and then download them.

[Y0ngg4n]

@JPinSPACE ah ok. so you added more items to the playlist and they did not got auto downloaded?

[JPinSPACE]

Yep, correct

[Y0ngg4n]

Yep, correct

i think that is a case not covered yet. Please create a seperate issue describing the problems in detail and link this issue please. Thx.

[JPinSPACE]

Ahh, gotcha, will do, thanks.

[Y0ngg4n]

@JPinSPACE thank you 🙂

[Venryx]

Hitting the same issue, where I add one song to a previously-downloaded album (which is really just a container folder on my desktop/server), and I'm unable to append it to my downloaded songs without deleting the whole album first then redownloading from scratch.

The code in question seems to be here:

finamp/lib/components/AlbumScreen/download_button.dart

Lines 43 to 56 in 0b38574

	setState(() {
	isDownloaded = _downloadsHelper.isAlbumDownloaded(widget.parent.id);
	});
	}
	return ValueListenableBuilder<Box<FinampSettings>>(
	valueListenable: FinampSettingsHelper.finampSettingsListener,
	builder: (context, box, child) {
	bool? isOffline = box.get("FinampSettings")?.isOffline;
	return IconButton(
	icon: isDownloaded
	? const Icon(Icons.delete)
	: const Icon(Icons.file_download),

Seems the minimum steps required would be to:

1. Improve the isAlbumDownloaded function to return more granular results than just "is downloaded or not" (perhaps a middle state of "partially downloaded" would be sufficient).
2. When an album is "partially downloaded", have the button show the "download" icon rather than "delete". (perhaps a modified version of the download icon to indicate that some of the album's tracks were already downloaded)
3. Improve the album download function to ignore downloading any tracks that it sees already exist in the target folder. (possibly this is already the case)

[Venryx]

Oh, I see that someone created a pull-request for another way to solve this issue!: #460

It adds a whole new button to update all locally-downloaded playlists, it looks like. (not completely sure if the "playlists" includes "albums", but I'm assuming it does...)

Not sure which approach is better, but since one is already written and ready to go, that seems preferable. (and anyway, it'd be possible to implement a second way to update it later)

[Chaphasilor]

#534 will add a button in each playlist that will synchronize all songs (download new ones, delete removed ones if they're not part of another downloaded playlist/album). This should close the issue.

It's not automatic (yet), but we'll get there!