Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when asking to download an album in FLAC #351

Closed
arthurlutz opened this issue Oct 14, 2022 · 5 comments
Closed

Warning when asking to download an album in FLAC #351

arthurlutz opened this issue Oct 14, 2022 · 5 comments
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@arthurlutz
Copy link

I have a music collection comprised of a mix of MP3s and FLACs. When downloading some albums for offline listening, it would be great if finamp could warn me when trying to download a FLAC album which might fill up my SD card, I would rather have 5 MP3 albums to listen to than 1 FLAC album (the sound quality of the android device can't really make it worthwhile to have FLAC in this usecase).

@jmshrv
Copy link
Owner

jmshrv commented Oct 27, 2022

We could probably add a size indicator on the album screen (may already be planned in the redesign? I can't remember off the top of my head), what constitutes a warning changes depending on the person.

@Chaphasilor
Copy link
Collaborator

Size indicator isn't planned, only a codec/quality indicator.

There could also be a setting that allows users to specify which codecs should trigger a confirmation?

And if we can get the actual file sizes from the Jellyfin API that could also be added to that setting as a simple threshold (per-track size maybe)...

@3ThumbsUp
Copy link

I'm not sure how feasible it is, but for me a preferable solution would be to have the jellyfin server transcode flac to mp3 and download it. My entire music collection is in flac, but I have no use for that on my phone.

@jmshrv
Copy link
Owner

jmshrv commented Jan 27, 2023

I'd like to add transcoded downloads, there's an open issue for it at #215

@jmshrv
Copy link
Owner

jmshrv commented Feb 13, 2023

File size has been implemented as part of transcoded downloads, closing this

@jmshrv jmshrv closed this as completed Feb 13, 2023
@Chaphasilor Chaphasilor added the redesign-beta Issues related to the beta/redsigned version of Finamp label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
None yet
Development

No branches or pull requests

4 participants