Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-download new songs from lists already set to download when connected to wifi #38

Closed
jonnyswan01 opened this issue May 14, 2021 · 8 comments
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@jonnyswan01
Copy link

not sure if this was supposed to work this way, but your download feature reminds a lot of what google play music did where you would set a playlist to download and then when you added a song to the playlist, that song would automatically download once you hit wifi. So, if you wanted it to work this, it currently does not. The new song just sits there, not downloaded while all the others are. Thanks!

@asgardius
Copy link
Contributor

An update button could be a good alternative

@perniczech
Copy link

Yes, please! Would likely make this app the Play Music replacement 🥳

@drazil100
Copy link

drazil100 commented Jul 16, 2021

I agree with the idea of having syncing instead of just straight up downloading. As I mentioned in #76 there are some issues with the current implimentation in that it assumes that the contents of the albums and playlists on the server don't change. I think that given that the content available is based on a server that if the server contents change it should update on the device (with the option to wait till you are on wifi). This should include removed songs as well as added songs.

@Swizzler121
Copy link

Also ran into this issue, it's super annoying that to update a downloaded playlist you have to delete the entire playlist from your device, then re-download the entire playlist. The ability to just sync over the added/removed songs would be great.

@jmshrv
Copy link
Owner

jmshrv commented Apr 29, 2022

An update button would be pretty easy to implement, I'll maybe fit it in the next minor release if I make one :)

@Fale
Copy link

Fale commented Jun 1, 2022

This can be part of #213, I think

@Chaphasilor
Copy link
Collaborator

@jonnyswan01 the download system has been improved as part of the redesign beta. It will now sync all downloaded collections and songs when you start it while in online mode. There's also an option to only download when connected to WiFi.
You can check the beta out here: https://github.com/jmshrv/finamp/releases/tag/0.9.2-beta

Do you have any more thoughts on when Finamp should synchronize with the server? Every time WiFi is reconnected seems excessive, and I'm not sure Android or iOS will let us do that. There is a dedicated sync button on the downloads page, but maybe some of you have an even better solution?

@Chaphasilor
Copy link
Collaborator

Adding a song to a playlist will now (in the beta) also automatically download that song if the playlist was already downloaded. If you have Finamp set to only download over WiFi, it will of course not download while you're on mobile data. The download would then be queued and automatically started as soon as you're connected to WiFi.

I'll close this issue for now, let me know if anything isn't working in the beta!

@Chaphasilor Chaphasilor added the redesign-beta Issues related to the beta/redsigned version of Finamp label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
Status: Done
Development

No branches or pull requests

8 participants