Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.1.6 broke compatibility with PHP 7 #13

Open
luenemam opened this issue Oct 20, 2023 · 1 comment · May be fixed by #14
Open

v1.1.6 broke compatibility with PHP 7 #13

luenemam opened this issue Oct 20, 2023 · 1 comment · May be fixed by #14

Comments

@luenemam
Copy link

With v 1.1.7 on PHP 7.4 i get:

Fatal error:
Declaration of MutableTypedData\Data\ArrayData::offsetExists(MutableTypedData\Data\mixed $offset):
bool must be compatible with ArrayAccess::offsetExists($offset) in /var/www/html/vendor/joachim-n/mutable-typed-data/Data/ArrayData.php on line 66

The type hints were introduced in PR #9
@joachim-n
Copy link
Owner

Hi. I'm not supporting PHP 7 any more, as it's EOL. Sorry - I should have increased the PHP requirement in composer.json.

Thanks for reporting though!

@luenemam luenemam linked a pull request Nov 6, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove require php:^7.0 luenemam/mutable-typed-data
2 participants
@joachim-n @luenemam