Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.75: The update stops in an intermediary state when one of the TSH files outside of the layout folder is locked by Windows #698

Open
Wolfy76700 opened this issue Jan 24, 2024 · 0 comments
Labels
bug Something isn't working critical This bug needs to be solved before others (Usually bugs with no viable workarounds for the user)

Comments

@Wolfy76700
Copy link
Collaborator

When updating the program, if a file outside of the layout folder is being locked by the Windows OS for any reason, the program will crash while leading the user to believe the update has succeeded. However this puts the program in an intermediary state where some files have beeh updated but not others, and the layout folder is renamed, but no new layout folder is present.

Here’s an extract from the log:

[2024-01-24 19:33:11] - ERROR - TournamentStreamHelper.py:ExtractUpdate:209 | Traceback (most recent call last):
  File "src\TournamentStreamHelper.py", line 204, in ExtractUpdate
    tar.extract(m)
  File "tarfile.py", line 2100, in extract
  File "tarfile.py", line 2173, in _extract_member
  File "tarfile.py", line 2214, in makefile
PermissionError: [Errno 13] Permission denied: 'assets\\font\\RobotoCondensed.ttf'

Proposed fix:

  • The program checks that any and all files which the update would change are either missing or editable before starting the update procedure, and informs the user if an issue is found, without updating any file
  • Check if TSH itself is using the culprit file

Workaround:

  • Redownload the software from GitHub and import the user_data folder
@Wolfy76700 Wolfy76700 added bug Something isn't working critical This bug needs to be solved before others (Usually bugs with no viable workarounds for the user) labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical This bug needs to be solved before others (Usually bugs with no viable workarounds for the user)
Projects
None yet
Development

No branches or pull requests

1 participant