Proxy.sslServers race condition

[fopinappb]

node-http-mitm-proxy/lib/proxy.ts

Line 677 in 310a3bc

getHttpsServer(hostname, (err, port) => {

...
https server started for www.google.com on 54724
https server started for www.google.com on 54726
...

With concurrent requests to www.google.com this semaphore is but the asynchronous callback (that populates sslServers) is outside the lock/sem.

This results in 2+ sslServers created for the same hostname yet only the last is tracked in the dictionary. This also means only the last one is cleaned up upon Proxy.close() resulting in lingering handles...

[WGH-]

This can be kinda worked around with forceSNI: true which doesn't create extra HTTPS servers.