Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_do_resize broken on Windows #2

Open
guntars opened this issue Feb 4, 2011 · 3 comments
Open

_do_resize broken on Windows #2

guntars opened this issue Feb 4, 2011 · 3 comments

Comments

@guntars
Copy link

guntars commented Feb 4, 2011

in
$command .= ' -quality 100 -geometry '.escapeshellarg($width).'x'.escapeshellarg($height).'!';
the trailing '!' parameter breaks execution on windows machines (throws an error complaining about an invalid argument. Un-escaping the exclamation mark fixes it, e.g.
$command .= ' -quality 100 -geometry '.escapeshellarg($width).'x'.escapeshellarg($height).'!';

@joelpittet
Copy link
Owner

Didn't even know that there was a windows distribution. Does this fix work on Linux as well?

@guntars
Copy link
Author

guntars commented Feb 7, 2011

Yes, there is a windows distro, and a Mac OS one, too. Some people use these as their dev machines, running a local webserver.

AFAIK the fix works on Ubuntu, don't know about the rest. Has to be verified!

@joelpittet
Copy link
Owner

Ok cool, send me a pull request and I will merge this change in or I will make the change in the next few days or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants