Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust parsing of responses #11

Open
joeroe opened this issue Jan 20, 2021 · 0 comments
Open

More robust parsing of responses #11

joeroe opened this issue Jan 20, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@joeroe
Copy link
Owner

joeroe commented Jan 20, 2021

The parsing functions (intchron_extract() and intchron_tabulate()) currently just extract specific elements from the listified JSON response based on what other functions needed. Specifically, they assume the important data is contained in a "records" array. But according to the schema (http://intchron.org/schema) and in implementing #5 and #6 I encountered other data structures.

Rather than continuing to pile kludges into intchron_extract(), we should have a generalised R representation of the response data. Probably with a dedicated S3 class as suggested by https://cran.r-project.org/web/packages/httr/vignettes/api-packages.html.

This was referenced Jan 20, 2021
joeroe added a commit that referenced this issue Jan 20, 2021
@joeroe joeroe added the enhancement New feature or request label Jan 20, 2021
@joeroe joeroe modified the milestones: v0.2, v1.0 Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant