Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail gracefully with HTTP errors #2

Open
joeroe opened this issue Oct 11, 2020 · 2 comments
Open

Fail gracefully with HTTP errors #2

joeroe opened this issue Oct 11, 2020 · 2 comments
Labels
bug Something isn't working
Milestone
v0.2

Comments

@joeroe
Copy link
Owner

joeroe commented Oct 11, 2020

It doesn't appear to be unusual for the IntChron servers to wobble when hitting it with the volume of requests intchron() queries can generate. These shouldn't cause fatal errors (which, if nothing else, stop vignettes and examples building and R CMD check passing). The functions should attempt to recover, e.g. by waiting a while and retrying, and as a last resort return what data they could get with a warning.
@joeroe
Copy link
Owner Author

joeroe commented Oct 12, 2020

Useful reading: https://httr.r-lib.org/articles/api-packages.html

@joeroe joeroe closed this as completed in 94b5971 Oct 12, 2020
@joeroe
Copy link
Owner Author

joeroe commented Oct 12, 2020

Reopening because R CMD check still sometimes fails with this error message:

Timeout was reached: [intchron.org] Resolving timed out after 10000 milliseconds

I've yet to be able to reproduce it locally.

@joeroe joeroe reopened this Oct 12, 2020
@joeroe joeroe added this to the v0.2 milestone Oct 13, 2020
@joeroe joeroe added the bug Something isn't working label Oct 13, 2020
joeroe added a commit that referenced this issue Oct 19, 2020
@joeroe
Generalise delimited file reading with intchron_read_delim(). See #2
ec7ded5 
Add core function intchron_read_delim() with aliases read_intchron_csv(), read_intchron_tsv() and read_intchron_txt()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
1 participant
@joeroe