Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where empty string returns nothing #43

Open
johnchase opened this issue Apr 6, 2017 · 0 comments
Open

Fix bug where empty string returns nothing #43

johnchase opened this issue Apr 6, 2017 · 0 comments

Comments

@johnchase
Copy link
Owner

If the existing list passed to create cualids contains an empty string the function returns nothing:

for id_ in cualid.create_ids(n=7, id_length=4, existing_ids=['']):
    print(e)

If an empty string is valid it should not return nothing, if it is not valid it should throw a warning. I don't feel an empty string should be considered valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant