Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome and Firefox on Android #142

Open
rhandberg opened this issue Nov 18, 2016 · 4 comments
Open

Chrome and Firefox on Android #142

rhandberg opened this issue Nov 18, 2016 · 4 comments

Comments

@rhandberg
Copy link

rhandberg commented Nov 18, 2016

If running the script in Chrome or Firefox on Android, the script will throw the "graceful" Android-error when using HTTP POST requests. Should this error not only be for the stock Android browser?

And if not, please add a callback that can be called instead of the Android "graceful" message.

@rhandberg rhandberg changed the title Chrome lo Chrome and Firefox on Android Nov 19, 2016
@AndrewFreese
Copy link

If you change line 159 to
} else if (userAgent.indexOf('android') !== -1 && userAgent.indexOf('chrome') === -1) {

Chrome on android works fine. I guess you'd need to add a firefox clause too.

@johnculviner
Copy link
Owner

good call lemme get a fix for this!

@Greibit
Copy link

Greibit commented Jul 5, 2017

@johnculviner How about this?

@johnculviner
Copy link
Owner

Yeah... just had a baby so stuff is getting a little difficult to keep up with, anyone using the library right now (i am not) having this issue mind taking a stab at it and i'm happy to take a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants