Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabs to be persistent on scroll #1072

Open
nguyetv opened this issue Mar 6, 2019 · 3 comments
Open

Fix tabs to be persistent on scroll #1072

nguyetv opened this issue Mar 6, 2019 · 3 comments

Comments

@nguyetv
Copy link

nguyetv commented Mar 6, 2019

When you scroll up, the tabs should persist at the top of the page. Currently it's cutting off the header image (see screenshot)

@nguyetv
Copy link
Author

nguyetv commented Mar 6, 2019

screen shot 2019-03-06 at 2 51 47 pm

@am9u
Copy link
Contributor

am9u commented Mar 6, 2019

@nguyetv To clarify, by "persistent" do you mean that:

  • Once the user scrolls past the hero image, that the top of the "Approved | In Progress | Rejected" tab bar should be set at a fixed position right under the top navigation
  • The page content should scroll freely underneath the fixed tab navigation

@nguyetv
Copy link
Author

nguyetv commented Apr 8, 2019

@am9u yes, that is correct. Thanks for clarifying questions, and clearer bullet descriptions. I will try to make better tickets next time <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants