Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fail messaging for transfer tokens on Brave #1082

Open
nguyetv opened this issue Mar 11, 2019 · 1 comment
Open

Fix fail messaging for transfer tokens on Brave #1082

nguyetv opened this issue Mar 11, 2019 · 1 comment

Comments

@nguyetv
Copy link

nguyetv commented Mar 11, 2019

"during the course of transferring tokens to be able to vote (in the Brave browser). I purchased 100 tokens, and tried to deposit 50. It claimed that this doesn't exceed my available balance... isn't that a good thing? I went back and was able to transfer 40 and then another 10. This was the only way I could complete the transaction."

@dankins
Copy link
Member

dankins commented Mar 11, 2019

Is it possible this is an off-by-one issue? Maybe we are setting the approved transfer amount equal to what they want to deposit, but whatever is checking is looking for "less than" instead of "less than or equal" approved tokens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants