Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ringing? #15

Open
zhuker opened this issue Sep 9, 2019 · 3 comments
Open

ringing? #15

zhuker opened this issue Sep 9, 2019 · 3 comments

Comments

@zhuker
Copy link

zhuker commented Sep 9, 2019

can any of the binaries also generate ringing artifacts as described here
https://bavc.github.io/avaa/artifacts/ringing.html
image

@joncampbell123
Copy link
Owner

That's a good one, it will give it that authentic "I was recorded in the mid 1980s" look since some master tapes from that time period seem to have it.

Look up practically any 1980s Computer Chronicles episode on the Internet Archive and you'll see it.

@zhuker
Copy link
Author

zhuker commented Feb 18, 2020

@joncampbell123 whats a good way to emulate it?

@joncampbell123
Copy link
Owner

I'm not sure at what point the ringing artifact is happening, so there are two possibilities for where to apply the filter.

If the ringing artifact only happens in the luminance channel, then apply it to the Y channel when it's still YIQ before separation to color subcarrier.

If the ringing artifact happened to the composite signal, then apply the filter when the frame is a black and white image with color subcarrier. The ringing artifact looks like it's not high frequency enough to screw up the color but high enough for the artifacts to cause false color.

All you need to write then is a routine that tracks the pixels vs a value that you add/subtract a weighted value against such that it deliberately overshoots and undershoots when the picture changes suddenly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants