Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some image files can't be mounted #4820

Closed
2 tasks done
leoxxx opened this issue Feb 13, 2024 · 33 comments
Closed
2 tasks done

Some image files can't be mounted #4820

leoxxx opened this issue Feb 13, 2024 · 33 comments
Labels

Comments

@leoxxx
Copy link

leoxxx commented Feb 13, 2024

Question

Some .fdi and .hdi files can't be mounted, but they can be mounted by anex86, T98-Next and Neko Project 21/W.

Have you checked that no similar question(s) exist?

  • I have searched and didn't find any similar question.

Code of Conduct & Contributing Guidelines

  • I agree to follow the code of conduct and the contributing guidelines.
@leoxxx leoxxx changed the title Why some image file can't be mounted? Some image files can't be mounted? Feb 13, 2024
@maron2000
Copy link
Contributor

You can show an example, can't you?

@leoxxx
Copy link
Author

leoxxx commented Feb 13, 2024

You can show an example, can't you?

D.O. Doki Doki Disk 8.hdi.zip

@leoxxx leoxxx changed the title Some image files can't be mounted? Some image files can't be mounted Feb 13, 2024
@joncampbell123
Copy link
Owner

The HDI image is so small, that IMGMOUNT doesn't consider it a hard disk image, because anything smaller than 2880 sectors (2.88MB) is assumed to be a floppy disk.

@joncampbell123
Copy link
Owner

Fixed. Images with file extension .hdi are now assumed to be a hard disk image which allows the image to mount.

@leoxxx
Copy link
Author

leoxxx commented Feb 14, 2024

@joncampbell123
boot.zip
It's a .fdi whcih can't be mounted.
Add a .nfd.
Tenshi-tachi no Gogo.zip
It's a T98FDDIMAGE.R0

@maron2000
Copy link
Contributor

I think problem of hdi & fdi images are fixed by #4825.
Please check.

@leoxxx
Copy link
Author

leoxxx commented Feb 16, 2024

Does it fix the .nfd? Where is the release? I want to test it.

@maron2000
Copy link
Contributor

maron2000 commented Feb 16, 2024

It's not released yet, but you can try the latest nightly build.
I haven't checked your nfd sample yet, but I tested hdi & fdi images myself.

fdi

fdi2

@maron2000
Copy link
Contributor

maron2000 commented Feb 16, 2024

Your provided nfd image seems not a MS-DOS formatted disk. It can't be read on MS-DOS running on np21 as well.

IMGMOUNT 0 [.nfd file]
boot a:

seems to work.

nfd2

nfd3

@leoxxx
Copy link
Author

leoxxx commented Feb 16, 2024

21/W is not 21.
https://simk98.github.io/np21w/
Please try this one.

2024-02-16_110611
21/W is O.K.

https://github.com/joncampbell123/dosbox-x/assets/5364709/6ebd6958-9ac4-43ba-a18f-e2b76d39e414
Can't be mounted on PC-98 mode.

@maron2000
Copy link
Contributor

You didn't carefully read my comment.
Boot MS-DOS on np21/w and type the commands I did before complaining.
Also, the procedure you showed in the video doesn't follow my instructions.
Very dissapointing.

@leoxxx
Copy link
Author

leoxxx commented Feb 16, 2024

https://github.com/joncampbell123/dosbox-x/assets/5364709/f3548514-e388-4886-bb7c-dd353f5effad

Not work. Black screen. What could go wrong?

Now I understand what you said. The .nfd can't be list directory, can go to the drive, but the dir command is failed.

@maron2000
Copy link
Contributor

Yes, you can't IMGMOUNT a: an image when it is not MS-DOS formatted.

And for the blank screen, it is very strange. As I already uploaded the screenshot, it is working for me.
I tried on VS x64 SDL2 nightly build and old 2023.09.01 VS x64 SDL1 release (the screenshot below).
Since I can't reproduce, we have to see what other differences are there.

nfd4

@leoxxx
Copy link
Author

leoxxx commented Feb 16, 2024

Information about NFD r0
https://www.pc98.org/project/doc/nfdr0.html

Information about other image
https://www.pc98.org/project/fivec.html

I hope these documents can help to fix the issue.

@leoxxx
Copy link
Author

leoxxx commented Feb 17, 2024

Add .hdm.
O.K.hdm.zip can be mount
error.1.hdm.zip cant' be mounted

https://dosbox-x.com/wiki/Guide:Managing-image-files-in-DOSBox‐X
I don't find .hdm from this url, so I also upload the O.K. one.

@maron2000
Copy link
Contributor

You can try the latest nightly for the unmountable hdm file.
Also, you can boot the image by imgmount 0 even with the current release.

@leoxxx
Copy link
Author

leoxxx commented Feb 17, 2024

2023.10 version imgmount 0 and boot a: no effect.
How can I get the nightly? I'll try later.

@maron2000
Copy link
Contributor

Very strange. The hdm boots fine on 2023.10.06 release.
hdm

Anyway, you can find nightly builds quite easily.
nightly

@leoxxx
Copy link
Author

leoxxx commented Feb 17, 2024

2024-02-17_192323
If boot a: will force close.
dosbox-x.zip My conf here.
I see.
Another question, how do I swap disk if imgmount 0?
Test nightly for .hdm, it's O.K.
.fdi need imgmount 0.
.nfd still black screen.
.hdi is O.K.
@maron2000
Which lng file cause dosbox-x garbled characters?

@maron2000
Copy link
Contributor

You can change the image to load from the dropdown menu.
Consult the wiki for details, the address is what you mentioned above.

boot.fdi you provided successfully mounts as well.

And your question about lng file, I have no idea since I usually don't use translations myself.
Does it matter with mounting the images?

change

boot

@leoxxx
Copy link
Author

leoxxx commented Feb 17, 2024

Garbled characters will make me can't understand the command wether it succeed. I remain US, JP, zh_CN and zh_tw, then no garbled characters.
Still have some garbled characters
So strange. I can't mount the .fdi. I will upload the gif.
GIF 2024-2-17 22-02-35
Maybe try vs build.
Thanks your reply.

@leoxxx
Copy link
Author

leoxxx commented Feb 17, 2024

@joncampbell123 @maron2000
Really, the .fdi bug only in the MingGW build, VS bulid is O.K. But .nfd still black screen in VS bulid.

@maron2000
Copy link
Contributor

We have to check what's going on in MinGW builds.
The blank screen problem is another issue, I think mounting itself is okay.

@joncampbell123
Copy link
Owner

@joncampbell123 @maron2000 Really, the .fdi bug only in the MingGW build, VS bulid is O.K. But .nfd still black screen in VS bulid.

Can you check if it has something to do with whether or not "rb" is needed for fopen() or O_BINARY is needed for open()?

Remember that on DOS/Windows systems, functions like open()/read()/write() by default have that translation mode to convert between \r\n and \n and back and that can screw with binary formats if you're unaware.

@maron2000
Copy link
Contributor

I currently work on Visual Studio to fix and test, so if I have some time I will try MinGW as well, ofcourse considering your advise.
Whether the fixes are working on Linux and/or mac, may matter on where and how to fix.

@maron2000
Copy link
Contributor

maron2000 commented Feb 20, 2024

MinGW build couldn't fetch the BPB parameters at all, so currently it will not work.
We have to see why.

@maron2000
Copy link
Contributor

Fixed the mounting issue for MinGW builds.
Please confirm.

@leoxxx
Copy link
Author

leoxxx commented Feb 20, 2024

dosbox-x-mingw-win64-20240220143038 Failed.

@maron2000
Copy link
Contributor

That's too bad. I can't reproduce, so I think something is wrong in your environment.

fdi
fdi2

@leoxxx
Copy link
Author

leoxxx commented Feb 21, 2024

@maron2000
Same config file, the VS build is O.K and MinGW is error. What is it caused by?
@joncampbell123
https://github.com/joncampbell123/dosbox-x/actions/runs/7977124696
dosbox-x-mingw-win64-20240220165609
This build is O.K.
So, what could go wrong?

@maron2000
Copy link
Contributor

I don't have any intention to find out what is wrong in the older versions, as long as it is working with the latest nightly.
You can find out yourself.

@leoxxx
Copy link
Author

leoxxx commented Feb 21, 2024

Add another can't be mounted .hdi file.
Rusty.zip
dosbox-x-mingw-win64-20240221033525 failed.
This is the same game another version .hdi file. It's O.K.
Rusty.zip

@maron2000
Copy link
Contributor

Fixed the mounting error. (Of course tested the image that failed in the current release)

rusty

@leoxxx leoxxx closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants