-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpm: Escape { and } characters in filenames #2088
base: main
Are you sure you want to change the base?
Conversation
* Add test coverage for escaping { and } filename characters Fixes #2087
Looks like this fails on the Github ubuntu-22.04 runner, but I'm not sure how to debug further as I cannot find the actual image Github uses published anywhere. There's tooling to build all the images, but the instructions appear to require Azure which I do not have resources to use. Tests pass locally for me, but I'm on macOS with rpm v4.19.1.1. The Github actions documentation claims that the Ubuntu 22.04 image includes rpm 4.17.0 I don't know anything more about the failure at this time. I won't merge until I understand that problem. |
I'm unable to find a way to use Github Actions images, so I tried to reproduce this outside. Best I can tell, rpm v4.19 works, but v4.17 does not. I tested manually with this rpm spec:
Looking at the rpm release notes, I found this excerpt:
This refers to rpm-software-management/rpm#1749 which seems pretty relevant. Times like these remind me that maybe #54 would be a nice improvement. I did a bit of testing and learned a few small things:
They install fine on rpm v4.18 and older:
|
I think I can make this specific test |
RPM 4.19 added some changes to make it easier or at least more consistent to escape 'unusual' filename characters. However, RPM v4.18 and earlier do not benefit from this change, so I'm hoping that replacing {} with ? (wild-card single) characters will work on those versions. It works fine on v4.19.
Escaping |
Fixes #2087