Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect display for German numbers #526

Open
maakle opened this issue Jun 13, 2023 · 3 comments
Open

Incorrect display for German numbers #526

maakle opened this issue Jun 13, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@maakle
Copy link

maakle commented Jun 13, 2023

Currently it shows phone numbers like this:

Screenshot 2023-06-13 at 18 16 22

It should be 160 1212123 so it wrongly adds 1 digit too much. Is there a way how I can adjust this or custom render it? One solution could also simply be a setting to deactivate the formatting.

@jorisre jorisre added the bug Something isn't working label Jul 19, 2023
@jorisre
Copy link
Owner

jorisre commented Jul 19, 2023

@maakle can you provide the phone number prefixed +49 and the expected output? I want to be sure we're taking of the same thing. Thanks!

@maakle
Copy link
Author

maakle commented Jul 20, 2023

Sure, German mobile phone numbers have either 3 or 4 digits as prefix after the country code. Examples:
+49 160 1212123
+49 1577 1212123

They start either with 15, 16 or 17. You can find a detailed list here: https://en.wikipedia.org/wiki/List_of_dialling_codes_in_Germany

Actually only number that start with 15 potentially have 4 digits. See here from the link above:

157

  • 1570 vistream
  • 1573 ALDITalk
  • 1577 E-Plus
  • 1579 sipgate

So I guess you need to check if it starts with 157 and then the prefix will be 4. Otherwise it's 3. Does that make sense?

@maakle
Copy link
Author

maakle commented Jul 20, 2023

Btw I think also a feature which deactivates the formatting would be cool. In that case no formatting is better than wrong formatting. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants