Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporating Xarray #63

Open
josephhardinee opened this issue Jan 3, 2018 · 2 comments
Open

Incorporating Xarray #63

josephhardinee opened this issue Jan 3, 2018 · 2 comments

Comments

@josephhardinee
Copy link
Owner

I would like to incorporate XArray into PyDSD to make many of the operations much easier (In particular, netCDF writing).
Here is my proposal, I would like some feedback.

All entries in fields become DataArrays. All coordinates will be stored in a DropSizeDistribution.coords. We will add properties for time, diameter, velocity bin to point into the coords dictionary. Most things will be able to stay the same as far as how they work. The one bigger change is the values would now be accessed as something like DropSizeDistribution['Nd'].values instead of by ['data'].

Benefits: We can autoroll datasets and make writing much easier. Xarray objects are easier to work with and this opens the possibility of possibly adding some dask integrations as well.

@nguy and anyone else that has a vested interest, I would love to get your feedback. The actual work to write the changes will be pretty quick I believe.

One big thing I have not figured out how to address is making sure all of the lengths stay in sync. This is a problem with our current implementation as well though so we don't lose anything here.

@saveriogzz
Copy link

Hi @josephhardinee and @nguy ! I am very interested in this and definitely can help out!

@josephhardinee
Copy link
Owner Author

@saveriogzz that would be great. I responded in email about a few of your other issues. Once we can get some of those coming along I'd love to meet with you and I can explain the approach I had in my head (I should probably write it up here as well) and see if that interests you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants