Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SealedBox support ? #126

Open
om26er opened this issue Mar 9, 2019 · 2 comments
Open

SealedBox support ? #126

om26er opened this issue Mar 9, 2019 · 2 comments

Comments

@om26er
Copy link

om26er commented Mar 9, 2019

It seems libsodium-jni doesn't implement SealedBox, are there plans to implement that ?

We use libsodium-jni is autobahn and require SealedBox for a feature and are willing to help make that happen.

@om26er
Copy link
Author

om26er commented Mar 13, 2019

@joshjdevl ping!

I found this implementation (https://github.com/abstractj/kalium/blob/master/src/main/java/org/abstractj/kalium/crypto/SealedBox.java) of SealedBox, probably something we can bring into this repository, what are your thoughts on that ?

@joshjdevl
Copy link
Owner

Hi @om26er

I initially had something similar in the repo early on. However, the issue is that only at encryption or decryption is an error thrown. In addition, it is a runtime error which, if left uncaught, will terminate the application.

I would suggest a better pattern to enforce when the container object is constructed that the public and private key is in the correct format and encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants