Skip to content
This repository has been archived by the owner on May 7, 2022. It is now read-only.

no_implicit_prelude does not work at crate level #84

Open
joshuajbouw opened this issue Jan 11, 2021 · 3 comments
Open

no_implicit_prelude does not work at crate level #84

joshuajbouw opened this issue Jan 11, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@joshuajbouw
Copy link
Owner

Opened to track rust's fix.

no_implicit_prelude is handy if you want to know exactly what you are using in your library, allowing you to slim it down later as you typically have all your new prelude imports altogether. Cuts down on code as well, cleaning things up drastically.

The issue is that #![no_implicit_prelude] at lib level used to work fine. Then Serde support was added and it wouldn't build Serde since it too uses no_implicit_prelude. There was a work around though which worked. Problem is, now that workaround is broken. While the project will build fine, this is problematic for documentation.

See: rust-lang/rust#80372

Temp workaround: #83

@joshuajbouw joshuajbouw added the bug Something isn't working label Jan 11, 2021
@siler
Copy link

siler commented Mar 5, 2021

The re-export strategy also breaks the Bundle derive macro after bevyengine/bevy#1525. I ended up removing the lib prelude in my local branch since I couldn't figure out how to fix it.

@joshuajbouw
Copy link
Owner Author

I'll be addressing that as soon as I can fix some other parts.

@joshuajbouw
Copy link
Owner Author

Ah whoops, this shouldn't be closed right now. Still should be tracked.

@joshuajbouw joshuajbouw reopened this Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants