Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lndconnect support for easy Zap integration #129

Closed
JimmyMow opened this issue Jan 3, 2019 · 2 comments
Closed

lndconnect support for easy Zap integration #129

JimmyMow opened this issue Jan 3, 2019 · 2 comments

Comments

@JimmyMow
Copy link

JimmyMow commented Jan 3, 2019

Description of the Feature or Idea

I think it would be cool if Joule supported lndconnect (or some format for passing auth info)

With this we (Zap) can host a "Connect to Joule" type of button offering much cleaner onboarding UX for users.

Existing Example(s) of Feature

User downloads Zap and Joule. Syncs to the chain and opens channels in Zap, clicks "Connect to Joule" and is authed into Joule.

@wbobeirne
Copy link
Member

wbobeirne commented Jan 5, 2019

I've taken a look at this, and there are two key problems:

  1. Joule exists only in the browser context, so there's not a way to have a link clicked in another context communicate with Joule, unlike native apps that can register a custom URI handler. This would require Joule to have a native component, as outlined in Consider native app companion #106.
  2. The current lndconnect format doesn't distinguish between the REST and gRPC APIs (and based on the examples, assumes gRPC) but Joule needs to use the REST API due to browser limitations (Which could also be solved with a native app.)

I'm all in favor of being compatible with this URI format, but I think it would require a native application on my end.

@JimmyMow
Copy link
Author

Ah ok, makes sense. well, I will close this issue for now. Hopefully something simpler will arise in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants