Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not recreate the address each time as I would like to double check before sending funds #214

Open
marsrobertson opened this issue May 28, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@marsrobertson
Copy link

  1. I want to deposit into Joule
  2. The BTC address is shown
  3. Copy the address
  4. Go to my other wallet to send $20 as suggested here
  5. Double check the address
  6. 🤔

Suggested solution

image

@wbobeirne
Copy link
Member

This totally makes sense, but is unfortunately the default behavior of LND to generate a new one on each request. Might make sense to keep a local cache, though I worry that this might unintentionally lead to address reuse. If there are suggestions on how to improve it and account for both cases, I'm all ears.

@wbobeirne wbobeirne added the enhancement New feature or request label May 28, 2019
@marsrobertson
Copy link
Author

Totally aware that address reuse is not OK and should not be encouraged.

Thinking about workarounds, caching, heuristics (keep it for 30 minutes unless incoming transaction) but I'm worried it will add work and complexity at a cost of even more confusion.

Now at least it is consistent - new address each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants