Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically create invoices #78

Open
wbobeirne opened this issue Dec 10, 2018 · 2 comments
Open

Automatically create invoices #78

wbobeirne opened this issue Dec 10, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@wbobeirne
Copy link
Member

If a webln.makeInvoice passes a fixed amount, we should just automatically generate the invoice for the website. This should be something you can configure on and off in the enable screen, if for some reason you don't want it (e.g. you need to balance liquidity.) It should also be rate limited to avoid spamming the user's node (e.g. if they request another invoice within a few seconds, either reject or prompt the user this time.)

@wbobeirne wbobeirne added the enhancement New feature or request label Dec 10, 2018
@musdom
Copy link

musdom commented Dec 19, 2018

If the invoice macaroon is also uploaded, users can skip the password prompt.

@fiatjaf
Copy link

fiatjaf commented Apr 18, 2019

Is this still being considered? Perhaps add a new flag to makeInvoice so app developers can explicitly request this -- as today they may be using makeInvoice(sat_amount) instead of the correct object as parameter the spec defines and that kinda means they don't know what they're doing and that they more-or-less expect the user to handle the invoice manually as always.

Or perhaps just require them to explicitly pass the object with the fixed amount and a description. Most apps don't pass a description, I think, and having automatic invoices created with a default description is not a good experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants