Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added # to beginning of regexp #52

Closed
wants to merge 1 commit into from
Closed

Added # to beginning of regexp #52

wants to merge 1 commit into from

Conversation

dexter2cz
Copy link

@jparise
Copy link
Owner

jparise commented Nov 30, 2021

Everything following the # is part of the URI "fragment" rather than the query string. We haven't touched fragments before (see #10), and I unfortunately don't think this is the correct way to handle them.

@jparise jparise linked an issue Nov 30, 2021 that may be closed by this pull request
Recognize UTM parameters in fragments #10
Open
@jparise
Copy link
Owner

jparise commented Dec 22, 2021

Closing this for now. Please reopen if you have more information that relates to my comment above.

@jparise jparise closed this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recognize UTM parameters in fragments
2 participants
@dexter2cz @jparise