Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag spike/crash when player's head is generated as a trade #223

Open
Parthodys opened this issue Jan 26, 2024 · 1 comment
Open

Lag spike/crash when player's head is generated as a trade #223

Parthodys opened this issue Jan 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Parthodys
Copy link

Parthodys commented Jan 26, 2024

Describe the bug
Sometimes when a player talks to a Wandering Trader and it happens to have a player's head, the server lags/crashes for a moment. https://pastebin.com/h4XzxJvu

To Reproduce
Steps to reproduce the behavior:

  1. Have lots of potential players for heads
  2. Talk to a Wandering Trader with playerhead trades enabled
  3. Server lags, disconnecting everyone and almost crashes
  4. If server recovers, the head is tradeable

Expected behavior
Player head trade generated without lag.
If there are too many heads to choose from, implement some maximum search time or something.

Server Software and Version:

  • Vendor: git-Paper-318
  • Minecraft Version: 1.20.2

Additional context
We have had this issue before when running 1.19, updating server & plugin to 1.20.2 did not fix this issue. We have also attempted to limit the amount of players whose heads can be traded by only granting the permission to certain ranks. We also have Bedrock users via Geyser with a dot in front of their names.

@Parthodys Parthodys added the bug Something isn't working label Jan 26, 2024
@Parthodys
Copy link
Author

Was anything done with this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant