Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitter Design #2383

Closed
1 of 10 tasks
bhoppers2008 opened this issue Sep 12, 2023 · 12 comments
Closed
1 of 10 tasks

Splitter Design #2383

bhoppers2008 opened this issue Sep 12, 2023 · 12 comments

Comments

@bhoppers2008
Copy link

bhoppers2008 commented Sep 12, 2023

Description

Describe the pattern

Context

Describe scenarios where the pattern is most applicable

Extra information

UITK Splitter docs can be found here.
Salt Splitter could make use of a third party library.
Consider if Salt Splitter should be compatible with Salt layout components (Border layout/ Parent Child layout/ etc).

Need to work with desktop / multi-window environment (e.g. used in a desktop Dialog)

Tasks

Preview Give feedback
@joshwooding
Copy link
Contributor

TODO: investigate https://github.com/bvaughn/react-resizable-panels

@mark-tate
Copy link
Contributor

Zazu Goal: M(5)

  • define token/characteristics
  • ready for dev by EOS

@shey-v
Copy link
Contributor

shey-v commented Jul 3, 2024

  • token/characteristics discussion took place today where Darrin/Paul/Zhihao decided a direction to take (Shey is awaiting a color contrast ratio query from Jared before she can decide on color values to apply to the default state of splitter)
  • component specs WIP
  • site examples WIP

@mark-tate
Copy link
Contributor

Goal: finalise site examples (already ready for dev)

@shey-v
Copy link
Contributor

shey-v commented Jul 11, 2024

  • Site docs / examples being refined based on convo today with Zhihao
  • Tokens being added by Paul today to Salt 1 & 2 libraries
  • Shey working on finalizing Figma component (once tokens have been added to library)
  • Shey working on Figma guide

@pseys
Copy link
Contributor

pseys commented Jul 12, 2024

The following tokens need to be created. I've added them as variables within the Salt Next Style library in Figma (to be published).

Characteristic Palette Light Dark
--salt-separable-foreground --palette-foreground-primary black white
--salt-separable-background --palette-alpha-none transparent transparent
--salt-separable-foreground-hover --palette-foreground-primary black white
--salt-separable-background-hover --palette-alpha-weak black A15% white A15%
--salt-separable-foreground-active --palette-foreground-primary-alt white white
--salt-separable-background-active --palette-accent blue-500 / teal-500 blue-500 / teal-500

The following token needs to be created. I've added it into the variables within Salt Next Style Library (to be published).

Foundation High Medium Low Touch
--size-border-stronger 4px 4px 4px 4px

@pseys
Copy link
Contributor

pseys commented Jul 12, 2024

Salt (Next) Styles library update published in Figma.

@pseys
Copy link
Contributor

pseys commented Jul 12, 2024

Salt 'current' palette tokens

Characteristic Palette Light Dark
--salt-separable-foreground --palette-neutral-primary-foreground gray-900 white
--salt-separable-background --palette-alpha-none transparent transparent
--salt-separable-foreground-hover --palette-neutral-primary-foreground gray-900 white
--salt-separable-background-hover --palette-neutral-tertiary-separator black A15% white A15%
--salt-separable-foreground-active --palette-interact-cta-foreground white white
--salt-separable-background-active --palette-accent-background blue-500 blue-500

@shey-v
Copy link
Contributor

shey-v commented Jul 15, 2024

  • Site docs / examples ready for dev
  • Added (Salt 1 & Next) in branch, Figma guide and QA in progress
  • Working on accessibility spec

@shey-v
Copy link
Contributor

shey-v commented Jul 17, 2024

  • Under final design review

@shey-v
Copy link
Contributor

shey-v commented Jul 19, 2024

  • Addressing feedback from Ben after design review
  • Have merged Figma component to Salt Next and Salt Current libraries (component will stay hidden until the build is completed)

@shey-v
Copy link
Contributor

shey-v commented Jul 25, 2024

  • Feedback from Ben has been addressed and the spec + site docs are in a 'ready for dev' state.
  • Few unknowns on implementation approach until build has begun (agreement with Josh/Zhihao to tweak + update specs or docs once the implementation has begun).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

8 participants