Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationItem uses aria-current="page" which prevents it from being used in Table of Contents #3009

Closed
1 of 10 tasks
joshwooding opened this issue Feb 12, 2024 · 1 comment
Closed
1 of 10 tasks
Labels

Comments

@joshwooding
Copy link
Contributor

Package name(s)

Core (@salt-ds/core)

Package version(s)

latest

Description

Navigation Item uses aria-current="page" which is correct for primary navigation but not ideal for a table of contents, which should use aria-current="true".

Steps to reproduce

No response

Expected behavior

aria-current should be able to be passed and overriden.

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@joshwooding joshwooding added type: bug 🪲 Something isn't working status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. labels Feb 12, 2024
@joshwooding
Copy link
Contributor Author

This can be solved with #3417

@joshwooding joshwooding removed the status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants