Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox in Figma library not compatible with border radius #3170

Closed
pseys opened this issue Mar 22, 2024 · 1 comment
Closed

Checkbox in Figma library not compatible with border radius #3170

pseys opened this issue Mar 22, 2024 · 1 comment
Assignees
@bhoppers2008
Labels
Figma role: design 🎨

Comments

@pseys
Copy link
Contributor

pseys commented Mar 22, 2024

During the work to apply border radius as an option to components in the live Figma library it was identified that Checkbox fails to display correctly in all densities with radius turned on.

Ben and Paul reviewed this, but were unable to find a satisfactory solution. The issue needs further investigation and may require structural changes to the way the component is designed in Figma. This won't affect code.

The other components with border radius are displaying correctly so could potentially be merged and published without Checkbox being completed, if time is an issue.
@pseys pseys modified the milestones: Salt 2.0, Q4 2023 Mar 22, 2024
@pseys
Copy link
Contributor Author

pseys commented Jul 18, 2024

This issue has now been resolved and rounded corners have been applied as part of the Salt Next Component and Pattern library.

@pseys pseys closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhoppers2008 bhoppers2008

Labels
Figma role: design 🎨
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshwooding @bhoppers2008 @pseys