Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay close button overlaps with content when no title is used #3532

Closed
1 of 10 tasks
origami-z opened this issue Jun 7, 2024 · 5 comments
Closed
1 of 10 tasks

Overlay close button overlaps with content when no title is used #3532

origami-z opened this issue Jun 7, 2024 · 5 comments
Assignees
@tomhazledine @dplsek
Labels
component: overlay priority: high 😡

Comments

@origami-z
Copy link
Contributor

origami-z commented Jun 7, 2024 •
edited
Loading

Package name(s)

Core (@salt-ds/core)

Package version(s)

1.28.0

Description

In HD, overlay content will be overlapped with close button. And scroll bar will also overlay with close button.

Steps to reproduce

https://stackblitz.com/edit/salt-template-s3xizl?file=App.tsx,index.tsx

Expected behavior

No response

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@origami-z origami-z changed the title Overlay close button overlays with content when no title is used Overlay close button overlaps with content when no title is used Jul 2, 2024
@tomhazledine
Copy link
Contributor

  • Final amends following review to account for unpredictable source-order of OverlayPanel contents.
  • Ready for review.

@tomhazledine tomhazledine mentioned this issue Jul 3, 2024
Closed
10 tasks
@bhoppers2008
Copy link

Pending design review from @bhoppers2008

@joshwooding joshwooding linked a pull request Jul 8, 2024 that will close this issue
Density-aware overlay close-button spacing #3533
Closed
@origami-z
Copy link
Contributor Author

What's the latest design decision on this? @bhoppers2008

@tomhazledine
Copy link
Contributor

Change of approach following discussion with design team. New approach will address this and #2970 together.

New issue: #3839

@bhoppers2008 bhoppers2008 assigned dplsek and unassigned bhoppers2008 Jul 19, 2024
@mark-tate
Copy link
Contributor

mark-tate commented Aug 5, 2024 •
edited by origami-z
Loading

Covered by new Header Block component #3839

@joshwooding joshwooding mentioned this issue Aug 5, 2024
Closed
@joshwooding joshwooding removed the type: bug 🪲 Something isn't working label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomhazledine tomhazledine

@dplsek dplsek

Labels
component: overlay priority: high 😡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Density-aware overlay close-button spacing jpmorganchase/salt-ds
6 participants
@mark-tate @origami-z @tomhazledine @joshwooding @bhoppers2008 @dplsek