Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a legacy theme to the Salt (Next) Figma library #3626

Closed
pseys opened this issue Jun 24, 2024 · 8 comments
Closed

Add a legacy theme to the Salt (Next) Figma library #3626

pseys opened this issue Jun 24, 2024 · 8 comments

Comments

@pseys
Copy link
Contributor

pseys commented Jun 24, 2024

EOS: Legacy theme tested and released to Salt (Next) Figma library

@pseys
Copy link
Contributor Author

pseys commented Jun 24, 2024

Due to unforeseen theme tasks (tokens for #3325 , #3535, #3310 ) I haven't been able to start this task within the current sprint. However, I have been able to give it some thought and I know how the issue can be resolved. It's a sizeable piece of work, but it should be achievable within 1-2 sprints including QA testing.

@mark-tate
Copy link
Contributor

Goal: L(11)
theme tested and released to Salt (Next) Figma library by EOS

@bhoppers2008
Copy link

@pseys to rescope to separate pieces of work (and create relevant new issues) + identify which will be completed in this sprint.

@pseys
Copy link
Contributor Author

pseys commented Jun 27, 2024

Rescoping into 3 parts:

  • Create variables library containing Salt-current foundation colours published locally
  • Create variables library containing Salt-current palette tokens published locally
  • Add Mode options to Characteristics variables
    -- Salt Legacy light
    -- Salt Legacy dark
    -- Salt Next

@pseys
Copy link
Contributor Author

pseys commented Jul 1, 2024

Speaking with @bhoppers2008 this morning, there is an urgent need to publish a release note for Salt Next documentation by EOW. This will be a significant effort, so will take priority over the Salt (Next) Legacy theme.

@mark-tate
Copy link
Contributor

Goal: agree the strategy by EOS

@joshwooding joshwooding changed the title Salt (Next) Legacy theme Add Legacy theme to the Salt (Next) Figma library Jul 18, 2024
@joshwooding joshwooding changed the title Add Legacy theme to the Salt (Next) Figma library Add a legacy theme to the Salt (Next) Figma library Jul 18, 2024
@pseys
Copy link
Contributor Author

pseys commented Jul 18, 2024

The proposed approach to enable Salt legacy theme within the Salt Next variables library is as follows:

The last task will come with conditions:

  • The characteristic variables will need modes applied; Salt Next and Salt Legacy (TBC)
  • Each characteristic variable mode will need to be mapped to a different set of palette variables – the Salt Next characteristics are already aligned to Accent / Mode in the styles library. Salt Legacy will need to map to a 'Mode' only switch, either in the same file or from a different library (TBC)
  • When creating a new design, components will default to Salt Next, but designers will have the ability to toggle to Salt Legacy if they wish, however, they will have to set mode separately

@pseys
Copy link
Contributor Author

pseys commented Jul 18, 2024

All follow-up tasks created as issues.

@pseys pseys closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants