Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Body:Link style from Salt-Next style library #3629

Closed
pseys opened this issue Jun 24, 2024 · 5 comments
Closed

Remove Body:Link style from Salt-Next style library #3629

pseys opened this issue Jun 24, 2024 · 5 comments

Comments

@pseys
Copy link
Contributor

pseys commented Jun 24, 2024

On 20-June Figma released an update allowing text style overrides without the need to detach styles. This means we can now apply underlines (to simulate a link) to any existing styles without the need for a dedicated 'Link' style.

  • Remove the body/link style from Salt (Next) Styles library
  • Set the font style for Link component in Salt (Next) Component library to body and apply an underline
@pseys pseys self-assigned this Jun 24, 2024
@pseys pseys converted this from a draft issue Jun 24, 2024
@pseys pseys changed the title Remove Body/Link style from Salt-Next style library Remove Body:Link style from Salt-Next style library Jun 24, 2024
@bhoppers2008 bhoppers2008 assigned yunjungyeh and navkaur76 and unassigned pseys and yunjungyeh Jul 7, 2024
@navkaur76
Copy link
Contributor

navkaur76 commented Jul 19, 2024

Branch merged in Figma (update to Link component), pending the removal of the body/link token from Salt (Next) Styles library from @pseys

@pseys
Copy link
Contributor Author

pseys commented Jul 22, 2024

The Salt (Next) Styles Library has now been updated. The Body/Link style has been removed and the update published.

@navkaur76
Copy link
Contributor

FYI a release note for this will be required to explain that there seems to be a Figma bug which doesn't display a "(U)" as expected next to the typography style in the design panel, indicating that the text has an underline. @yunjungyeh

@yunjungyeh
Copy link
Contributor

Added (Note: a Figma bug that doesn't display the abbreviation "(U)" as expected next to the typography style in the design panel, indicating that the text has an underline.) to the latest release note (for 23 July release)

@mark-tate
Copy link
Contributor

done to be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants