Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ag grid Countries symbol looks bigger in HD Compact in ag grid theme v2 #3775

Closed
3 of 10 tasks
origami-z opened this issue Jul 8, 2024 · 2 comments · Fixed by #3812
Closed
3 of 10 tasks

Ag grid Countries symbol looks bigger in HD Compact in ag grid theme v2 #3775

origami-z opened this issue Jul 8, 2024 · 2 comments · Fixed by #3812
Assignees
@origami-z
Labels
component: country symbol package: ag-grid-theme priority: high 😡

Comments

@origami-z
Copy link
Contributor

origami-z commented Jul 8, 2024 •
edited
Loading

Package name(s)

AG Grid Theme (@salt-ds/ag-grid-theme)

Package version(s)

v2

Description

Countries symbol in HD Compact grid looks large

in 1.14.0, it used to be smaller

salt-ds/packages/ag-grid-theme/css/salt-ag-theme.scss

Line 33 in 7c6437c

--salt-size-base: 16px;

Steps to reproduce

No response

Expected behavior

No response

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@origami-z origami-z added type: bug 🪲 Something isn't working status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. package: ag-grid-theme priority: high 😡 component: country symbol labels Jul 8, 2024
@origami-z origami-z self-assigned this Jul 8, 2024
@origami-z origami-z changed the title Countries symbol looks bigger in HD Compact in ag grid theme v2 Ag grid Countries symbol looks bigger in HD Compact in ag grid theme v2 Jul 9, 2024
@origami-z origami-z mentioned this issue Jul 15, 2024
Merged
6 tasks
@origami-z
Copy link
Contributor Author

Jul 17 - Snapshot release in #3822 confirmed the fix. Will do more regression test.

@mark-tate
Copy link
Contributor

To be released in next release

@github-actions github-actions bot mentioned this issue Jul 22, 2024
Merged
@joshwooding joshwooding removed the status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. label Oct 30, 2024
@joshwooding joshwooding removed the type: bug 🪲 Something isn't working label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@origami-z origami-z

Labels
component: country symbol package: ag-grid-theme priority: high 😡
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version Packages jpmorganchase/salt-ds
3 participants
@mark-tate @origami-z @joshwooding