Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer update document around modal only recommendation #3818

Closed
1 task done
origami-z opened this issue Jul 15, 2024 · 4 comments · Fixed by #4014
Closed
1 task done

Drawer update document around modal only recommendation #3818

origami-z opened this issue Jul 15, 2024 · 4 comments · Fixed by #4014

Comments

@origami-z
Copy link
Contributor

origami-z commented Jul 15, 2024

Area

UI Components

The problem

Drawer currently only supports overlaying entire screen. There are use cases where this should not cover the entire screen, e.g. drawer should not overlay app header.

The solution

Provide a mechanism to target certain container for the drawer and scrim to show up.

Need to work out accessibility implication

Alternatives and examples

Related to

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@mark-tate
Copy link
Contributor

Rather than build in Salt, add some docs to our site to explain the recommended alternatives ?
@mark-tate close and replace with new documentation ticket

@mark-tate
Copy link
Contributor

Cortado Goal: call to discuss alternatives and then add docs to site

@jake-costa
Copy link
Contributor

jake-costa commented Aug 8, 2024

ADA Feedback:
To make this work, we need to:
Remove aria-modal.
Remove the focus trap.
Reflow content so that it is not overlapped by the drawer when open and ensure appropriate focus order or have the drawer collapse when focus leaves the drawer.

Recommendation:
Instead of modifying the drawer component, I recommend using the side panel component. This approach addresses the request more effectively.

Resources:
https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/
https://www.w3.org/TR/WCAG21/#keyboard-accessible

@origami-z
Copy link
Contributor Author

origami-z commented Aug 16, 2024

Aug 16 - 2 steps

  1. document feedback above
  2. create a ticket for non-model drawer for future prioritize Non-modal Drawer #3968

@origami-z origami-z changed the title Drawer: configurable positioning / overlaid to part of screen Drawer update document around modal only recommendation Aug 20, 2024
@joshwooding joshwooding self-assigned this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

4 participants