Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show controlled example code for components #3250

Open
1 task done
origami-z opened this issue Apr 15, 2024 · 0 comments · May be fixed by #3864
Open
1 task done

Show controlled example code for components #3250

origami-z opened this issue Apr 15, 2024 · 0 comments · May be fixed by #3864
Labels
status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: documentation Improvements or additions to documentation type: enhancement 💡 New feature or request

Comments

@origami-z
Copy link
Contributor

Area

UI Components, Documentation

The problem

Most interactive components doesn't have controlled examples. Although "How to use" tab sometimes showing some information about this (e.g. Dropdown) with props table, it's not something most users will actively navigate to.

The solution

Add appropriate example code to all interactive components that can be controlled

e.g. ToggleButtonGroup need to use onChange={(e) => onChange(e.currentTarget.value)}.

Alternatives and examples

n/a

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@origami-z origami-z added type: documentation Improvements or additions to documentation type: enhancement 💡 New feature or request status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. labels Apr 15, 2024
@liamsms liamsms linked a pull request Jul 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: documentation Improvements or additions to documentation type: enhancement 💡 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant