Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitle prop to DialogHeader #3865

Closed
wants to merge 7 commits into from

Conversation

liamsms
Copy link
Contributor

@liamsms liamsms commented Jul 20, 2024

Closes #3800

  • Added an optional subtitle prop to DialogHeader, the subtitle renders directly below the header text.
  • Updated the dialog docs, storybook, and tests.

Copy link

changeset-bot bot commented Jul 20, 2024

⚠️ No Changeset found

Latest commit: 14fcfb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 20, 2024

@liamsms is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

@liamsms liamsms changed the title Add subtitle prop to dialog Add subtitle prop to DialogHeader Jul 20, 2024
@origami-z origami-z added the community For issues that have been raised by folks outside the core Salt team label Jul 22, 2024
@liamsms liamsms marked this pull request as ready for review July 22, 2024 13:42
@joshwooding
Copy link
Contributor

Thanks for the contribution @liamsms. We're still looking into the requirements for this feature, but we'll keep this PR open

@joshwooding joshwooding marked this pull request as draft July 22, 2024 14:02
@joshwooding
Copy link
Contributor

Thanks for the contribution @liamsms. We're still looking into the requirements for this feature, but we'll keep this PR open.

Hi @liamsms, Since then, we've decided to build a new component to accommodate feedback and other design changes for Dialog and similar structured components. Therefore, we won't be adding subtitle to the DialogHeader component. Currently, the subtitle is technically possible with composition using DialogHeader.

Thank you for your work.

@liamsms liamsms deleted the dialog-subtitle branch September 11, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community For issues that have been raised by folks outside the core Salt team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog subtitle support in additional to prehead
3 participants