Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align theme to figma #4486

Open
bhoppers2008 opened this issue Dec 10, 2024 · 3 comments
Open

Align theme to figma #4486

bhoppers2008 opened this issue Dec 10, 2024 · 3 comments
Assignees
Labels
package: theme Theme package

Comments

@bhoppers2008
Copy link

The new figma libraries release (end of 2025) simplifies our figma libraries down to a reduced set, primarily built around 1 set of components supporting 2 themes–UITK Legacy and JPM Brand.

How do we align the theme in code to mirror what design teams will providing tech teams in their documentation?

Notes from @bhoppers2008 discussion with @origami-z (10 Dec)

  • Salt will provide two themes (uitk and brand) for technical components.

  • Changing from these defaults is something a Business Library will own (i.e., i want the brand theme but blue buttons... not a Salt recommendation–technically possible but teams will have to maintain it themselves).

  • How do we get ourselves to a state where the defaults in code and figma are the same?

    • Salt Provider – Stays the same
    • Salt Provider Next – Deprecate
      • Or add a prop to the Next which changes the defaults
      • We still wouldn’t have the ‘Next Legacy’ in code though
    • Salt Provider Brand – Updated to be the same as the brand in Figma
      • Capability to support a Next Legacy theme but not the Salt recommendation–needs to be owned by the Business Library
      • Are there any open-source problems if we explicitly name the theme ‘JPM Brand’ and set the defaults to brand? Better as something more generic in code (i.e., ‘Brand’). Check with Sean if this is ok?
  • Should we consider removing ‘Accent’ from the new provider? Other styling options remain relevant under the hood but ‘accent’ is the difference between the UITK Legacy (blue) and JPM Brand (teal).

@joshwooding
Copy link
Contributor

Have we considered just adding support the the current SaltProvider? We have a theme prop that could be set to "brand". This would potentially be more future proof as we'd avoid adding another provider and it might work if they are using SaltProviderNext already.

@origami-z
Copy link
Contributor

not against reusing current provider, theme is tricky given there are teams using it as current use (classname), could be a breaking change?

@joshwooding
Copy link
Contributor

joshwooding commented Dec 13, 2024

not against reusing current provider, theme is tricky given there are teams using it as current use (classname), could be a breaking change?

I was thinking of "brand" being a predefined one, and the current use still being supported?

Edit: I guess the worry is that they are already using brand as a value and it might cause issues there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: theme Theme package
Projects
Development

No branches or pull requests

4 participants