Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events rendered with index key causes unexpected behavior #2694

Closed
5 tasks done
milkman4 opened this issue Dec 11, 2024 · 1 comment
Closed
5 tasks done

Events rendered with index key causes unexpected behavior #2694

milkman4 opened this issue Dec 11, 2024 · 1 comment
Labels

Comments

@milkman4
Copy link
Contributor

Check that this is really a bug

  • I confirm

Reproduction link

Incoming when I have time.

Bug description

The current TimeGridEvent component is rendered with a key of evt_${index}. When trying to maintain rendering state when attached to a child of this component, unexpected behavior occurs if an event is is removed or added from the event array.

Expected Behavior

Id expect that events can be uniquely identified beyond the index element of the array.

Actual Behavior

Events are key'd simply by array index.

react-big-calendar version

0.39.3

React version

17.0.2

Platform/Target and Browser Versions

Chrome

Validations

  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@milkman4
Copy link
Contributor Author

Fixed! thanks for the quick review @cutterbl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant